[FIX] Clarify that electrodes.tsv is optional for MEG, for use with simultaneous (i)EEG #1555
Conversation
effigies
added
MEG
effigies
force-pushed
the
fix/meg_electrodes
branch
from
7a9dfdd
to
2facc67
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1555 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
fix/meg_electrodes
branch
from
2facc67
to
befd54c
Compare
There was a problem hiding this comment.
Thanks @effigies!
Let's wait for further discussion based on my comment in:
There was a problem hiding this comment.
What do you think about this?
perhaps we should add a section about
electrodes.tsvto the MEG section of the BIDS specification, and make corresponding schema adjustments.
I see that you have opted for not adding a new section and instead adding this information under Recording EEG simultaneously with MEG. I think I'd be fine with that as well.
src/schema/rules/checks/meg.yaml
Outdated
| @@ -0,0 +1,14 @@ | |||
| # Rules for MEG data that cannot be defined in tables | |||
| --- | |||
| MEGElectrodesRecommended: | |||
There was a problem hiding this comment.
as outlined in #1550 (comment), I think this should be optional --> this electrode information can also be stored in _headshape.<ext> files or sometimes in the data file format itself (Elekta/Neuromag/MEGIN).
| @@ -98,8 +98,10 @@ it SHOULD be stored separately under a new `/eeg` data type | |||
| If however EEG is recorded simultaneously **with the same MEG system**, | |||
| it MAY be stored under the `/meg` data type. | |||
| In that case, it SHOULD have the same sampling frequency as MEG (see `SamplingFrequency` field below). | |||
| Furthermore, the EEG sensor coordinates SHOULD be specified using MEG-specific coordinate | |||
| systems (see [coordinates section](#coordinate-system-json-_coordsystemjson) below and | |||
| Furthermore, EEG sensor coordinates SHOULD be recorded in an | |||
There was a problem hiding this comment.
IMHO the SHOULD should become a MAY.
So far, the spec allowed for recording electrode positions in the _headshape: https://bids-specification.readthedocs.io/en/stable/glossary.html#headshape-suffixes
effigies
changed the title
Fixes #1550.